Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Tools config tooltips #1470

Merged
merged 7 commits into from
Aug 28, 2020
Merged

Tools config tooltips #1470

merged 7 commits into from
Aug 28, 2020

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Aug 27, 2020

Description

Add tooltips for the GDK tools configuration. Text copied from the upcoming docs page

https://improbableio.atlassian.net/browse/UTY-2471

Tests

Tooltips work

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Aug 27, 2020
@paulbalaji paulbalaji marked this pull request as ready for review August 27, 2020 16:53
@improbable-prow-robot improbable-prow-robot added A: tooling Area: Tooling and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 27, 2020
Co-authored-by: Jamie Brynes <jamiebrynes@improbable.io>
Copy link
Contributor

@seanjparker seanjparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question about the naming

CHANGELOG.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@paulbalaji paulbalaji merged commit c028616 into develop Aug 28, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/tools-config-tooltips branch August 28, 2020 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants