This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
labels
Aug 27, 2020
improbable-prow-robot
added
A: tooling
Area: Tooling
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Aug 27, 2020
paulbalaji
force-pushed
the
feature/tools-config-tooltips
branch
from
August 27, 2020 16:54
2c06c66
to
9ed0e6b
Compare
jamiebrynes7
approved these changes
Aug 28, 2020
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.tools/GdkToolsConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jamie Brynes <jamiebrynes@improbable.io>
seanjparker
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one question about the naming
Co-authored-by: Sean Parker <seanparker@improbable.io>
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: tooling
Area: Tooling
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tooltips for the GDK tools configuration. Text copied from the upcoming docs page
https://improbableio.atlassian.net/browse/UTY-2471
Tests
Tooltips work
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.